Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: #413

Merged
merged 6 commits into from
Aug 10, 2024
Merged

housekeeping: #413

merged 6 commits into from
Aug 10, 2024

Conversation

oyvindberg
Copy link
Owner

  • remove most unused warnings
  • introduce bleep.Discard to do so
  • bump bleep
  • optimize imports
  • fmt
  • enforce .model prefix

- remove unused warnings
- introduce `bleep.Discard` to do so
- bump bleep
- optimize imports
- fmt
- enfoece `.model` prefiz
Update aws-lambda-java-runtime-interface-client to 2.6.0 (#3980)
@oyvindberg
Copy link
Owner Author

there is a mountain of unused warnings for xml literals for scala 3 still, doesn't seem fixable unless rewritten into something else.

source level 3.4 is probably a far as we can go if we want to keep 2.13 cross compiled
There were some problems with the bloop upgrade, but it likely works again now
@KristianAN
Copy link
Contributor

yes, the warnings for xml literals is something we also have a lot of at $work. I have not found a workaround yet, and there does not seem to be much activity to fix it.

@oyvindberg oyvindberg merged commit 8415b25 into master Aug 10, 2024
7 checks passed
@oyvindberg oyvindberg deleted the housekeeping branch August 10, 2024 22:55
@oyvindberg
Copy link
Owner Author

yeah, also couldn't find anything except some old issues. I think the plan for the last decade has been to remove the xml literals and replace with string interpolators which nobody has written yet

@@ -32,7 +32,7 @@ case class InstallZshTabCompletions(userPaths: UserPaths, logger: Logger, stdout
println(completionScript)
} else {
logger.info(s"Writing $completionScriptDest")
FileSync.softWriteBytes(completionScriptDest, completionScript.getBytes(StandardCharsets.UTF_8)): Unit
FileSync.softWriteBytes(completionScriptDest, completionScript.getBytes(StandardCharsets.UTF_8)).discard()
Copy link
Contributor

@sideeffffect sideeffffect Aug 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just

val _ = FileSync.softWriteBytes(completionScriptDest, completionScript.getBytes(StandardCharsets.UTF_8))

?
There's no need to invent custom extension methods to do a simple thing like this...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Believe it or not, cross compiling between strict 2.13 and 3 provides no way to resolve all unused cases. And you need to use 3-4-5 different syntaxes to resolve most unused cases. It's laughable, really. Inventing this is way easier to deal with

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy 🙀 fair enough then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants