-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
housekeeping: #413
housekeeping: #413
Conversation
- remove unused warnings - introduce `bleep.Discard` to do so - bump bleep - optimize imports - fmt - enfoece `.model` prefiz Update aws-lambda-java-runtime-interface-client to 2.6.0 (#3980)
there is a mountain of unused warnings for xml literals for scala 3 still, doesn't seem fixable unless rewritten into something else. |
source level 3.4 is probably a far as we can go if we want to keep 2.13 cross compiled
There were some problems with the bloop upgrade, but it likely works again now
yes, the warnings for xml literals is something we also have a lot of at $work. I have not found a workaround yet, and there does not seem to be much activity to fix it. |
yeah, also couldn't find anything except some old issues. I think the plan for the last decade has been to remove the xml literals and replace with string interpolators which nobody has written yet |
@@ -32,7 +32,7 @@ case class InstallZshTabCompletions(userPaths: UserPaths, logger: Logger, stdout | |||
println(completionScript) | |||
} else { | |||
logger.info(s"Writing $completionScriptDest") | |||
FileSync.softWriteBytes(completionScriptDest, completionScript.getBytes(StandardCharsets.UTF_8)): Unit | |||
FileSync.softWriteBytes(completionScriptDest, completionScript.getBytes(StandardCharsets.UTF_8)).discard() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just
val _ = FileSync.softWriteBytes(completionScriptDest, completionScript.getBytes(StandardCharsets.UTF_8))
?
There's no need to invent custom extension methods to do a simple thing like this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Believe it or not, cross compiling between strict 2.13 and 3 provides no way to resolve all unused cases. And you need to use 3-4-5 different syntaxes to resolve most unused cases. It's laughable, really. Inventing this is way easier to deal with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh boy 🙀 fair enough then...
bleep.Discard
to do so.model
prefix