Refactor dependencies #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindberg
force-pushed
the
refactor-dependencies
branch
3 times, most recently
from
6da7eee to
2398439
Compare
- `model.VersionScalaPlatform` => `model.VersionCombo` - use `model.Dep` in `CoursierResolver` instead of `coursier.Dependency` - refactor and move scala suffix calculation to `Dep` from `VersionScalaPlatform`
oyvindberg
force-pushed
the
refactor-dependencies
branch
2 times, most recently
from
ceb0150 to
8948221
Compare
- have `Replacements` rewrite dependency versions as well
- collect replacement keys in Replacements companion
- don't infer ${SCALA_EPOCH}
- only support syntax with curly braces
oyvindberg
force-pushed
the
refactor-dependencies
branch
from
8948221 to
f836110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${PLATFORM_VERSION}and$SCALA_VERSIONin dependency versionsmodel.VersionScalaPlatform=>model.VersionCombomodel.DepinCoursierResolverinstead ofcoursier.DependencyDepfromVersionComboReplacementsrewrite dependency versions as well