Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model: Add strict mode #173

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Model: Add strict mode #173

merged 2 commits into from
Jul 26, 2022

Conversation

oyvindberg
Copy link
Owner

when true, add all scalac options for sbt-tpolecat to the given project

when true, add all scalac options for sbt-tpolecat to the given project
@oyvindberg oyvindberg merged commit 3a77bf7 into master Jul 26, 2022
@oyvindberg oyvindberg deleted the strict branch July 26, 2022 22:53
@@ -1283,7 +1274,13 @@ templates:
options: -Vimplicits -Vtype-diffs -Wconf:cat=other-match-analysis:error -Wdead-code
-Wextra-implicit -Wnumeric-widen -Wunused:explicits -Wunused:implicits -Wunused:imports
-Wunused:locals -Wunused:nowarn -Wunused:params -Wunused:patvars -Wunused:privates
-Wvalue-discard -Xlint:-byname-implicit -Xlint:deprecation -Xlint:strict-unsealed-patmat
-Wvalue-discard -Xlint:-byname-implicit -Xlint:adapted-args -Xlint:constant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all these new options here? Shouldn't adding strict: true be enough, so that all these options don't have to be stated explicitly?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is likely mismatched versions of sbt-tpolecat. If the set of flags discovered in the (in this case) tapir build do not contain all those produced by sbt-tpolecat for that particular scala version, the replacement with strict: true is not done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants