Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup CI build somewhat #171

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Speedup CI build somewhat #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ffdb26
github action: set CI: true
oyvindberg Jul 19, 2022
c8004bf
github action: only use `setup-graalvm` action on windows
oyvindberg Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ jobs:
run: cs install --channel channel bleep --verbose

- name: Run tests
env:
CI: true
Copy link
Contributor

@sideeffffect sideeffffect Jul 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this redundant? 🤔
https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's probably why I deleted the declarations in the first place, heh :)

I was trying to get the first branch taken here, but it somehow still didn't work. I just merged this branch without digging too much, as it'll need to be revisited very soon anyway.

The integration snapshot tests imports a bunch of real, complex sbt builds into bleep, and makes a bunch of property tests on the result. Currently all these other builds are git submodules which need to be checked out for every build, and coursier needs to resolve all the dependencies for all the builds. as a result the github action cache is absolutely enormous. My plan is to replace submodules with code which checks out the projects when needed, and try to wrestle coursier into resolving dependencies without actually downloading them.

run: |
bleep generate-resources
bleep test
Expand All @@ -54,7 +56,9 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: recursive
# todo: this is only needed because it makes some windows development stuff available. figure out how bleep can download it itself
- uses: graalvm/setup-graalvm@v1
if: runner.os == 'Windows'
with:
version: '22.1.0'
java-version: '17'
Expand All @@ -74,6 +78,8 @@ jobs:
if: runner.os != 'Windows'

- name: Test binary after build (non-windows)
env:
CI: true
run: ./${{ matrix.file_name }} --ignore-version-in-build-file test --no-color jvm213
if: runner.os != 'Windows'

Expand All @@ -93,6 +99,8 @@ jobs:

- name: Test binary after build (windows)
shell: cmd
env:
CI: true
# todo: fix tests on windows
run: .\${{ matrix.file_name }} --ignore-version-in-build-file compile --no-color jvm213
if: runner.os == 'Windows'
Expand Down