Add new flavor definition style, add bioinformatics flavor #4257
+30
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat provocative PR that does two things - no hard feelings if you reject either or both changes.
Proposed Changes
descriptors
andlinters
entries in flavor info returned frommegalinter.flavor_factory.list_megalinter_flavors()
list_megalinter_flavors()
can include pre-filleddescriptors
andlinters
lists. That seems to allow a flavor to be completely defined withinflavor_factory.py
.bioinformatics
flavor.Based on local testing this seems to work as expected - the bioinformatics Dockerfile builds and runs appropriately, and bioinformatics appears as a new flavor (including being linked from each "This linter is available in the following flavors" section).
From the outside this seems like a cleaner way to define flavors, but I easily could be missing some critical reason why the current method is necessary.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance