Generalized RDF-star #112
Merged
Generalized RDF-star #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it impossible to convert GeneralizedTerms to strict terms; however, this is actually not required for normal use. The only use was in testsuite, so instead I provided a conversion to OwnedQuad, OwnedTerm, etc.
* add precision to N-Triples and N-Quads parser documentation. The previous message was not totally accurate about allocations during parsing. * replace RDF* with RDF-star * add RDF-star in some places it was missing * replace "nested triple" and "embedded triple" with "quoted triple" also removed a few warnings (unused imports, unused names)
The generalized triple allocator enables generalized RDF-star. The generalized n-quads parser demonstrates that. TODO: use the generalized triple allocator in GTrig
|
I forgot to mention a few other changes:
Finally, I ran |
Tpt
reviewed
Dec 2, 2022
There was a problem hiding this comment.
Looks great to me! Thank you!
I found a few typos (not very important...)
About the CI failure, I have opened a bug in the Clippy repo about it: rust-lang/rust-clippy#10021
Tpt
force-pushed
the
main
branch
3 times, most recently
from
9ec634a to
2e61177
Compare
|
@Tpt thanks for these comments. I addressed them all (except for replacing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly extends the generalized parsers to support RDF-star.
In the process, I also updated the documentation, and some internal method, of the other parsers, to align with the latest terminology of RDF-star ("RDF-star" instead of "RDF*", "quoted triples" instead of "embedded triples").