Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation types #56

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fix installation types #56

merged 1 commit into from
Feb 23, 2023

Conversation

augustuswm
Copy link
Contributor

@augustuswm augustuswm commented Feb 22, 2023

  • Update app_id and installation_id in auth from u64 to i64

The spec defines these as integers which causes them to be generated as i64 fields. The manual auth implementations are using u64s and can cause overflows when cast to i64

@augustuswm augustuswm merged commit 883e764 into main Feb 23, 2023
@augustuswm augustuswm deleted the fix-installation-id branch February 23, 2023 13:08
kavin-kr pushed a commit to kavin-kr/third-party-api-clients that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant