Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Crucible to latest #538

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Update Crucible to latest #538

merged 2 commits into from
Oct 4, 2023

Conversation

leftwo
Copy link
Contributor

@leftwo leftwo commented Oct 3, 2023

The following updates are part of this new Crucible version:

Log crucible opts on start, order crutest options (#974) Lock the Downstairs less (#966)
Cache dirty flag locally, reducing SQLite operations (#970) Make stats mutex synchronous (#961)
Optimize requeue during flow control conditions (#962) Update Rust crate base64 to 0.21.4 (#950)
Do less in control (#949)
Fix --flush-per-blocks (#959)
Fast dependency checking (#916)
Update actions/checkout action to v4 (#960)
Use cargo hakari for better workspace deps (#956) Update actions/checkout digest to 8ade135 (#939)
Cache block size in Guest (#947)
Update Rust crate ringbuffer to 0.15.0 (#954)
Update Rust crate toml to 0.8 (#955)
Update Rust crate reedline to 0.24.0 (#953)
Update Rust crate libc to 0.2.148 (#952)
Update Rust crate indicatif to 0.17.7 (#951)
Remove unused async (#943)
Use a synchronous mutex for bw/iop_tokens (#946)
Make flush ID non-locking (#945)
Use oneshot channels instead of mpsc for notification (#918) Use a strong type for upstairs negotiation (#941)
Add a "dynamometer" option to crucible-downstairs (#931) Get new work and active count in one lock (#938)
A bunch of misc test cleanup stuff (#937)
Wait for a snapshot to finish on all downstairs (#920) dsc and clippy cleanup. (#935)
No need to sort ackable_work (#934)
Use a strong type for repair ID (#928)
Keep new jobs sorted (#929)
Remove state_count function on Downstairs (#927)
Small cleanup to IOStateCount (#932)
let cmon and IOStateCount use ClientId (#930)
Fast return for zero length IOs (#926)
Use a strong type for client ID (#925)
A few Crucible Agent fixes (#922)
Use a newtype for JobId (#919)
Don't pass MutexGuard into functions (#917)
Crutest updates, rename tests, new options (#911)

Log crucible opts on start, order crutest options (#974)
Lock the Downstairs less (#966)
Cache dirty flag locally, reducing SQLite operations (#970)
Make stats mutex synchronous (#961)
Optimize requeue during flow control conditions (#962)
Update Rust crate base64 to 0.21.4 (#950)
Do less in control (#949)
Fix --flush-per-blocks (#959)
Fast dependency checking (#916)
Update actions/checkout action to v4 (#960)
Use `cargo hakari` for better workspace deps (#956)
Update actions/checkout digest to 8ade135 (#939)
Cache block size in Guest (#947)
Update Rust crate ringbuffer to 0.15.0 (#954)
Update Rust crate toml to 0.8 (#955)
Update Rust crate reedline to 0.24.0 (#953)
Update Rust crate libc to 0.2.148 (#952)
Update Rust crate indicatif to 0.17.7 (#951)
Remove unused async (#943)
Use a synchronous mutex for bw/iop_tokens (#946)
Make flush ID non-locking (#945)
Use `oneshot` channels instead of `mpsc` for notification (#918)
Use a strong type for upstairs negotiation (#941)
Add a "dynamometer" option to crucible-downstairs (#931)
Get new work and active count in one lock (#938)
A bunch of misc test cleanup stuff (#937)
Wait for a snapshot to finish on all downstairs (#920)
dsc and clippy cleanup. (#935)
No need to sort ackable_work (#934)
Use a strong type for repair ID (#928)
Keep new jobs sorted (#929)
Remove state_count function on Downstairs (#927)
Small cleanup to IOStateCount (#932)
let cmon and IOStateCount use ClientId (#930)
Fast return for zero length IOs (#926)
Use a strong type for client ID (#925)
A few Crucible Agent fixes (#922)
Use a newtype for `JobId` (#919)
Don't pass MutexGuard into functions (#917)
Crutest updates, rename tests, new options (#911)
@leftwo
Copy link
Contributor Author

leftwo commented Oct 3, 2023

Let's hold on this PR, let me get the denagle PR in to crucbile and I'll update

Copy link
Collaborator

@pfmooney pfmooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is simply too much Nagle in this update as it stands.

@gjcolombo
Copy link
Contributor

There is simply too much Nagle in this update as it stands.

needs more Denaglebot

@pfmooney
Copy link
Collaborator

pfmooney commented Oct 3, 2023

There is simply too much Nagle in this update as it stands.

needs more Denaglebot

Now that's some automation I can get behind

all Crucible connections should set TCP_NODELAY (#983)
Use a fixed size for tag and nonce (#957)
@leftwo
Copy link
Contributor Author

leftwo commented Oct 3, 2023

Okay, now we have all the fixes in from crucible (for today).

@leftwo leftwo requested a review from pfmooney October 3, 2023 22:06
@leftwo leftwo merged commit 42c878b into master Oct 4, 2023
10 checks passed
@pfmooney pfmooney deleted the alan/crucible-now branch October 5, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants