propolis_client::api::InstanceProperties has unused fields

[gjcolombo]

propolis/lib/propolis-client/src/handmade/api.rs

Lines 172 to 189 in 6d815bb

	#[derive(Clone, Debug, Deserialize, PartialEq, Eq, Serialize, JsonSchema)]
	pub struct InstanceProperties {
	/// Unique identifier for this Instance.
	pub id: Uuid,
	/// Human-readable name of the Instance.
	pub name: String,
	/// Free-form text description of an Instance.
	pub description: String,
	/// ID of the image used to initialize this Instance.
	pub image_id: Uuid,
	/// ID of the bootrom used to initialize this Instance.
	pub bootrom_id: Uuid,
	/// Size of memory allocated to the Instance, in MiB.
	pub memory: u64,
	/// Number of vCPUs to be allocated to the Instance.
	pub vcpus: u8,
	}

The image_id and bootrom_id fields in this struct are, AFAICT, totally unused by anyone. The description field is also not used by the control plane (it passes "Test description" in all cases). We should remove these fields if possible to reduce the time spent initializing them and sending them around.

[gjcolombo]

Tracked more thoroughly by #723.