Move test generated clients into a buildable crate #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
force-pushed
the
build-generated
branch
from
246e0f6
to
01fe2b1
Compare
jayvdb
commented
Dec 3, 2023
| pub mod buildomat_builder; | ||
| pub mod buildomat_builder_tagged; | ||
| pub mod buildomat_cli; | ||
| //pub mod buildomat_httpmock; |
There was a problem hiding this comment.
commented out due to #637
|
What would you think about doing the |
|
Ya I can split it up |
This was referenced Dec 8, 2023
|
There is a lot of overlap, so would be good to get #641 in quickly. |
jayvdb
force-pushed
the
build-generated
branch
from
d759aca
to
e9d69fb
Compare
|
This PR now sits on top of #642 |
jayvdb
force-pushed
the
build-generated
branch
from
e9d69fb
to
2d83b24
Compare
jayvdb
changed the title
jayvdb
changed the title
jayvdb
force-pushed
the
build-generated
branch
from
2d83b24
to
a0529b9
Compare
|
@ahl , PR refreshed & green. |
jayvdb
force-pushed
the
build-generated
branch
from
a0529b9
to
c25101c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only moves them into a crate to allow building them.
The next step would be to add a CI job that builds them.