Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable github api test #445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Apr 27, 2023

Relates to #444

@jayvdb jayvdb marked this pull request as ready for review April 27, 2023 10:31
@@ -1168,7 +1168,6 @@ impl Generator {

// TODO to deal with multiple response types, we'll need to create an
// enum type with variants for each of the response types.
assert!(response_types.len() <= 1);
Copy link
Contributor Author

@jayvdb jayvdb Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes #344 degrade reasonably instead of failing. Usually the first responses is the most important one.

I can remove it by adding a lot more fiddling to test_github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant