Allow component names to contain underscores

[augustuswm]

When handling schema components that were generated from types containing generics, you often get components that have names like TypeX_for_TypeY. Currently the name matching regex does not match against the underscore and instead only captures up through TypeX.

This change allows for the _ character in type names.

I'm unsure where the appropriate place to write a test for this is. I can put one together if pointed in the right direction.

[david-crespo]

Maybe this could just be like .+? or \w+. or even .startsWith('#/components/schemas/')? No need to be this specific to begin with

[augustuswm]

Makes sense to me. I can see if the Open API spec has any guidance on allowed characters.

[augustuswm]

I think this answers it:

All the fixed fields declared above are objects that MUST use keys that match the regular expression: ^[a-zA-Z0-9\.\-_]+$.

[david-crespo]

Lol it resorted everything

[augustuswm]

Well know I want to know why...

[david-crespo]

I don't think this is working right. Every entry in the list has undefined for the second thing (the result of the JSON.stringify().match().map(), with or without this change.

export const getSortedSchemas = (spec: OpenAPIV3.Document) => {
  return topologicalSort(
    Object.keys(spec.components?.schemas || {}).map((name) => [
      name,
      JSON.stringify(spec.components!.schemas![name])
        .match(/#\/components\/schemas\/[a-zA-Z0-9.\-_]+$/g)
        ?.map((s) => s.replace("#/components/schemas/", "")),
    ])
  );
};

[david-crespo]

Thanks!