Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zod and msw stuff from @oxide/api #255

Merged
merged 3 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,22 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: "18"
- working-directory: "./oxide-api"
run: npm install
- name: Typecheck client
working-directory: "./oxide-api"
run: npm run tsc
- working-directory: "./oxide-openapi-gen-ts"
run: npm install
# TODO: this probably doesn't make sense anymore, it should be done already
- name: Generate client
run: "./tools/gen.sh"
- name: Typecheck
- name: Typecheck generator
working-directory: "./oxide-openapi-gen-ts"
run: npm run tsc
- name: Lint
- name: Lint generator
working-directory: "./oxide-openapi-gen-ts"
run: npm run lint
- name: Test
- name: Test generator
working-directory: "./oxide-openapi-gen-ts"
run: npm test run
8 changes: 0 additions & 8 deletions oxide-api/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,3 @@ if (result.type === "success") {
### Request bodies

### Responses: `ApiResult<T>`

## Other stuff in the package

Most likely nobody but us wants this, and we should take it out of the npm package.

### Mock Service Worker API skeleton

### Zod validators
15 changes: 2 additions & 13 deletions oxide-api/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 3 additions & 5 deletions oxide-api/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@oxide/api",
"version": "0.1.0-alpha.4",
"version": "0.1.0-alpha.5",
"description": "TypeScript client for the Oxide API",
"engines": {
"node": ">=18"
Expand All @@ -19,7 +19,8 @@
},
"scripts": {
"build": "tsup --dts",
"test": "echo \"Error: no test specified\" && exit 1"
"test": "echo \"Error: no test specified\" && exit 1",
"tsc": "tsc"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -50,8 +51,5 @@
"cjs",
"esm"
]
},
"dependencies": {
"zod": "^3.23.6"
}
}
Loading
Loading