-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish generator and client to npm #240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pretty close, but I'm running into an issue where the output file doesn't want to execute with
|
It worked in console! diff --git a/tools/generate_api_client.sh b/tools/generate_api_client.sh
index d6bd0d39..6779632e 100755
--- a/tools/generate_api_client.sh
+++ b/tools/generate_api_client.sh
@@ -17,7 +17,7 @@ GEN_DIR="$PWD/app/api/__generated__"
SPEC_URL="https://raw.githubusercontent.com/oxidecomputer/omicron/$OMICRON_SHA/openapi/nexus.json"
-npx tsx ../oxide.ts/generator/index.ts $SPEC_URL $GEN_DIR
+npx @oxide/[email protected] $SPEC_URL $GEN_DIR
npx prettier --write --log-level error "$GEN_DIR"
# hack until we start pulling this from npm. we don't want this file
|
This was referenced May 4, 2024
I am about ready to merge this and tackle the linked followup issues separately. |
This was referenced May 4, 2024
david-crespo
force-pushed
the
npm
branch
3 times, most recently
from
May 6, 2024 15:15
dfdbe2c
to
69c9165
Compare
david-crespo
force-pushed
the
npm
branch
2 times, most recently
from
May 6, 2024 16:46
be91f09
to
a501c99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
Closes #232