Add completions sub-command to generate shell completion scripts #592
Conversation
citrus-it
force-pushed
the
andy/generate
branch
from
4fd286a to
f950516
Compare
citrus-it
changed the title
citrus-it
force-pushed
the
andy/generate
branch
3 times, most recently
from
9e7c633 to
97e8037
Compare
citrus-it
force-pushed
the
andy/generate
branch
from
97e8037 to
2df87c9
Compare
cli/src/cmd_completion.rs
Outdated
| /// | ||
| /// and import this by adding the following to `~/.config/elvish/rc.elv` | ||
| /// | ||
| /// use oxide |
There was a problem hiding this comment.
Beautiful comment, might need formatting tweaks depending on how it renders on the docs site. I believe we treat this as markdown. Testing now.
There was a problem hiding this comment.
Yep. Working on a PR to this PR since my iteration cycle alone is a lot faster than me suggesting changes to you and you pushing commits and me testing them.
| pub struct CmdCompletion { | ||
| /// Type of the shell | ||
| #[clap(short, long)] | ||
| shell: Shell, |
There was a problem hiding this comment.
This comes out perfectly in the docs. Great.
Final product of my edit
CLI outputUglier than before but tolerable. I've added #593 about rendering this markdown in the CLI as well. 
|
There was a problem hiding this comment.
This looks great. My only concern is #594, separating meta commands like this from the rest in the docs site sidebar, but it's not a blocker.
|
Thanks for fixing up the docs site rendering! |
No description provided.