Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for SAML as a Silo IdP, part 1 #994
Support for SAML as a Silo IdP, part 1 #994
Changes from 1 commit
365050a
81dd77f
13b091d
1e87918
6be4f9f
ed33499
f55fada
ffc9f96
7595933
2566741
b578a99
463b1b6
99bcf08
a12939b
3ec5827
3eb6e98
115ffdd
3f8727a
6fbfec7
c2a8633
531c39f
f92964f
a93ed10
eb0ed4b
4cd4c55
2ef7da6
e77353c
b304994
0afecd6
0bf0847
2e35e06
7c1fbe4
044c82d
d835c45
8a6f954
b083fe5
8571681
1ed412e
74521e8
813876a
56320f3
6597d67
c9d369c
36d3588
5f352d0
fa10a10
9593b8f
378b2c1
dab03ea
46de770
6c42a7c
3393799
2f45e1a
fc0522d
302f878
140f697
f9e2011
609a7e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine we might want to add some context to this error (e.g., "failed to base64-decode public certificate"). As long as we're sticking with anyhow here, that's really easy with
.context()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how to proceed here, given fa10a10 adds "could not base64 decode" messages during deserialize. Given that the db model still uses String it's technically still possible that this decode will fail but it won't be seen by the user in the same way. I didn't try to shove openssl's types into the db, maybe I should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same about the error message.