Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the console to be served over HTTP, using session cookies #783

Merged
merged 4 commits into from
Mar 24, 2022

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Mar 17, 2022

  • We have been serving Nexus' external API over HTTP, not HTTPS. This is a known deficiency, tracked by TLS integration #249.
  • Session cookies, which are used when authenticating to the console, use the Secure attribute to ensure that they're exclusively sent over HTTPS.
  • @david-crespo has theorized that "this worked anyway" because the console had been typically accessed over localhost, and an exception was granted.

Until HTTPS integration is adopted across the stack more universally, allow the console to be served in the interim. This change is necessary to access Nexus-from-within-a-Zone, as it is no longer accessible over localhost.

This change should be undone once #249 has progressed.

@smklein smklein requested a review from david-crespo March 17, 2022 18:25
@david-crespo
Copy link
Contributor

Citation on the localhost thing:

A cookie with the Secure attribute is only sent to the server with an encrypted request over the HTTPS protocol. It's never sent with unsecured HTTP (except on localhost)

https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#restrict_access_to_cookies

@smklein smklein enabled auto-merge (squash) March 24, 2022 14:50
@smklein smklein merged commit 768f369 into main Mar 24, 2022
@smklein smklein deleted the console-in-zone branch March 24, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants