[omicron-package] add a way to show what Cargo commands will be run #7268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
smklein
reviewed
Dec 19, 2024
package/src/bin/omicron-package.rs
Outdated
| return Ok(()); | ||
| } | ||
| let release_command = cargo_plan.release.build_command("build", true); | ||
| let debug_command = cargo_plan.debug.build_command("build", true); |
There was a problem hiding this comment.
The second argument to build_command is a boolean called release - should it be false?
There was a problem hiding this comment.
Oh ugh... yeah. I'm going to make this an enum.
package/src/lib.rs
Outdated
| @@ -110,6 +111,7 @@ pub enum BuildCommand { | |||
| #[clap(long)] | |||
| intermediate: bool, | |||
| }, | |||
| /// List the build commands that will be run | |||
There was a problem hiding this comment.
Is this comment in the right spot? I don't think the Package command has changed in this PR
There was a problem hiding this comment.
No, whoops, not sure how it ended up there.
Created using spr 1.3.6-beta.1
smklein
approved these changes
Dec 19, 2024
sunshowers
deleted the
sunshowers/spr/omicron-package-add-a-way-to-show-what-cargo-commands-will-be-run
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to see what commands will be run, without actually running them.
As part of this, refactor
CargoPlanand change its meaning slightly -- it nowindicates the set of debug and release packages that would be built.
In the future, we'll be able to use these structures to add lints around which
features get built.