[reconfigurator] BlueprintBuilder cleanup 5/5 - Convert discretionary ensure_zone_multiple_* to add_zone_* #7107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plotnick
approved these changes
Nov 19, 2024
Comment on lines
-578
to
-584
| // TODO-cleanup This is awkward: the builder wants to know how many | ||
| // total zones go on a given sled, but we have a count of how many | ||
| // we want to add. Construct a new target count. Maybe the builder | ||
| // should provide a different interface here? |
There was a problem hiding this comment.
This was my very least favorite question in the planner. Thanks for answering it!
jgallagher
force-pushed
the
john/reconfigurator-storage-4
branch
from
a0c5837 to
f3652cc
Compare
jgallagher
force-pushed
the
john/builder-ensure-add
branch
from
2d3ada7 to
eaef3ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the callers of the
ensure_zone_multiple_*methods to add discretionary zones were, in practice, wanting to add a specific number of zones. This rewords all of those methods to be imperative, allowing us to remove a pretty significant chunk of now-unnecessary checks and logic.Builds on and is staged on top of #7106.