-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reconfigurator] BlueprintBuilder
cleanup 4/5 - when choosing a zpool, it must be from a disk present in the blueprint
#7106
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
235a74f
[reconfigurator] sled_select_zpool: Require chosen zpool to be on a d…
jgallagher bcf78ad
fix reconfigurator-cli integration test
jgallagher 48028fa
fix sim sled-agent gen check and executor tests
jgallagher b8a7670
remove unused imports
jgallagher 2905b18
expectorate
jgallagher 11c05fd
attempt to stabilize dataset row ordering in blueprint diffs after UU…
jgallagher 0498183
fix vpc test (no disks on sleds)
jgallagher fdfe91f
continue stabilizing dataset output in diffs
jgallagher fee229a
fixups from main
jgallagher 2371e04
expectorate
jgallagher 630ea16
better method name
jgallagher f3652cc
fix sim sled-agent generation check
jgallagher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, it is nice to get rid of this!