Add and use built-in users for OMDB #7062
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described and suggested in oxidecomputer#6600, create two built-in users to replace the test user for OMDB's purposes. Follows USER_INTERNAL_API and its read-only counterpart. Signed-off-by: Andriy Sultanov <[email protected]>
Use OMDB-specific users for establishing DB connections and doing DB queries. Use the read-only user by default, only use the read-write user when the "--destructive" argument is provided. Signed-off-by: Andriy Sultanov <[email protected]>
|
Hypothetically, these changes should mean that the code referenced in the original issue could be removed:
But I am not familiar enough with the codebase to recognize what duplication could be dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[nexus] Create read-write and read-only built-in users for OMDB
As described and suggested in #6600, create two built-in users to
replace the test user for OMDB's purposes. Follows USER_INTERNAL_API and its
read-only counterpart.
[omdb] Use properly authenticated OpContext
Use OMDB-specific users for establishing DB connections and doing DB queries.
Use the read-only user by default, only use the read-write user when the
"--destructive" argument is provided.