Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip failing api calls #7059

Merged
merged 1 commit into from
Nov 14, 2024
Merged

skip failing api calls #7059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dev-tools/ls-apis/tests/api_dependencies.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Clickhouse Cluster Admin for Keepers (client: clickhouse-admin-keeper-client)
Clickhouse Cluster Admin for Servers (client: clickhouse-admin-server-client)
consumed by: omicron-nexus (omicron/nexus) via 3 paths

Clickhouse Single-Node Cluster Admin (client: clickhouse-admin-single-client)
consumed by: omicron-nexus (omicron/nexus) via 2 paths

CockroachDB Cluster Admin (client: cockroach-admin-client)
consumed by: omicron-nexus (omicron/nexus) via 2 paths

Expand Down
12 changes: 7 additions & 5 deletions nexus/reconfigurator/execution/src/clickhouse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,13 @@ pub(crate) async fn deploy_single_node(
let admin_url = format!("http://{admin_addr}");
let log = opctx.log.new(slog::o!("admin_url" => admin_url.clone()));
let client = ClickhouseSingleClient::new(&admin_url, log.clone());
client.init_db().await.map(|_| ()).map_err(|e| {
anyhow!(
"failed to initialize single-node clickhouse database: {e}",
)
})
if let Err(e) = client.init_db().await {
warn!(
log,
"failed to initialize single-node clickhouse database: {e}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to want to do the same for keepers and replicated servers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! I'm going to do this very shortly.

);
}
Ok(())
} else {
Ok(())
}
Expand Down
Loading