Allow omicron to configure per-link tx_eq settings #6914
Conversation
| @@ -2355,6 +2355,10 @@ pub struct SwitchPortSettingsView { | |||
| /// Link-layer discovery protocol (LLDP) settings. | |||
| pub link_lldp: Vec<LldpLinkConfig>, | |||
|
|
|||
| /// TX equalization settings. These are optional, and most links will not | |||
| /// need them. | |||
| pub tx_eq: Vec<Option<TxEqConfig>>, | |||
There was a problem hiding this comment.
Is this collection truly variable in length, or can we expect a fixed length of optional values?
There was a problem hiding this comment.
Until we add support for breakout connectors and multiple links per port, the length will always be 1. I implemented this as a vector, as that is how all of the other per-link settings are represented in this struct.
There was a problem hiding this comment.
Hey @Nieuwejaar, I attached a few questions in order to get a better understand of how this feature is going to be used. Will we need to expose this to customers via the external api?
| /// TX equalization settings. These are optional, and most links will not | ||
| /// need them. |
There was a problem hiding this comment.
When will links need this setting? Is there an issue / document we can reference for this feature?
There was a problem hiding this comment.
This is needed for specific models of transceiver which don't autotune and don't work with the normal default settings. So far, we've only found one of those, and that is now hardcoded in dendrite. For now, this is for internal use only, by whoever is doing the initial customer install.
No description provided.