[reconfigurator] Retrieve keeper cluster config information #6606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karencfv
changed the title
andrewjstone
approved these changes
Sep 23, 2024
| let path = parent_dir.join(format!("{prefix}-oximeter-clickward-test")); | ||
| std::fs::create_dir(&path)?; | ||
|
|
||
| // We use the default ports in `test_schemas_disjoint` and must use a |
There was a problem hiding this comment.
nit: We should probably indicate that there are now multiple tests here using clickward and we need to ensure they all use distinct ports.
| /// Host of the keeper server | ||
| pub host: ClickhouseHost, | ||
| /// Keeper server raft port | ||
| pub raft_port: u16, |
There was a problem hiding this comment.
Can we keep this and other comments to 80 char lines please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit implements a new clickhouse-admin endpoint to retrieve and parse information from the ClickHouse virtual node
/keeper/configwhich contains the last committed cluster configuration.Purpose
The main purpose of retrieving this information is to have the ability to populate the inventory's
raft_configinClickhouseKeeperClusterMembership.omicron/nexus/types/src/inventory.rs
Lines 499 to 503 in 453311a
In a follow up PR an endpoint that specifically retrieves all information to populate
ClickhouseKeeperClusterMembership. This will be done by making several calls to theclickhouse keeper-clientand using the parsing function here to populateraft_config.The endpoint itself will be useful to retrieve information for debugging.
Manual testing
Related: #5999