[5/6] [nexus] add an indent level to external-api http entrypoints #6461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
|
Already accepted there so I'm just going to go ahead and land this with r+ andrew :) |
sunshowers
deleted the
sunshowers/spr/56-nexus-add-an-indent-level-to-external-api-http-entrypoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(re-do of #6372 which I accidentally landed on the wrong branch)
We're going to put all this in a trait soon, and this file is so large that I'd
rather not ruin blame. With this intermediate commit, it will be possible to
add this revision to
.git-blame-ignore-revs, thereby preserving blame.The diff is very large but it's not scary, literally just adding an indent via
a module.
(I should have also done this with some of our other APIs -- lesson learned!)