[dns-server] convert DNS server API into a trait #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
luqmana
approved these changes
Jul 13, 2024
| "url": "https://oxide.computer", | ||
| "email": "[email protected]" | ||
| }, | ||
| "version": "0.0.1" |
There was a problem hiding this comment.
Seems like all the migrated specs are all this version but should this be separate than the crate version?
There was a problem hiding this comment.
These are internal APIs that aren't currently versioned, so we're just using 0.0.1 as a placeholder.
sunshowers
changed the base branch from
sunshowers/spr/main.dns-server-convert-dns-server-api-into-a-trait
to
main
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/dns-server-convert-dns-server-api-into-a-trait
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward, and resulted in some nice cleanup.