[nexus] SNAT IP comes from same pool as ephemeral IP #5678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
force-pushed
the
snat-ip-respects-pool
branch
from
80cbac6 to
acf5759
Compare
david-crespo
commented
May 1, 2024
| @@ -1075,7 +1066,7 @@ mod tests { | |||
| &context.opctx, | |||
| id, | |||
| instance_id, | |||
| context.default_pool_id().await, | |||
| None, | |||
There was a problem hiding this comment.
All of these work as expected when given None to make it keep choosing the default pool, but there should probably now be a test for a non-None value.
david-crespo
commented
May 1, 2024
| assert_eq!( | ||
| error.message, | ||
| "not found: ip-pool with name \"nonexistent-pool\"" | ||
| ); |
There was a problem hiding this comment.
This used to complain about the default pool despite another pool being specified because the SNAT IP came from the default pool, and that failed before any ephemeral IP stuff came up.
david-crespo
commented
May 1, 2024
| // ephemeral IP comes from specified pool | ||
| assert_ip_pool_utilization(client, "pool2", 1, 5, 0, 0).await; | ||
| // ephemeral IP and SNAT IP come from specified pool, so +2 | ||
| assert_ip_pool_utilization(client, "pool2", 2, 5, 0, 0).await; |
There was a problem hiding this comment.
This is what is supposed to happen, so that's good.
david-crespo
changed the title
|
Based on the discussion in #5043 (comment), closing this because I think the right direction will be to instead
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5043
Like I said here, this is arguably a little strange when you think about it: why should the IP pool for the ephemeral IP also govern where the SNAT IP comes from? I'll definitely wait for confirmation from a networking knower that this is actually the desired behavior.