[test-utils] perform extra redactions at the beginning, not the end #5393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
sunshowers
added
the
Test Flake
1 task
davepacheco
approved these changes
Apr 3, 2024
sunshowers
deleted the
sunshowers/spr/test-utils-perform-extra-redactions-at-the-beginning-not-the-end
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a rare-but-clearly-possible flake seen in https://github.com/oxidecomputer/omicron/pull/5386/checks?check_run_id=23376436739.
It looks like what happened is that a temporary directory was generated with a
string that looked something like
/var/tmp/omicron_tmp/.tmp12msH9Y. Theredactor matched
12msbefore it matched the path.To avoid this, perform extra redactions before the usual ones. I believe this
is always correct -- if a user has passed in an extra redaction, it should
probably be handled before all others.