Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Repro bb8 issues #5351

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Repro bb8 issues #5351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion nexus/db-queries/src/db/datastore/rack.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,35 @@ impl DataStore {
info!(log, "Inserted services");

for physical_disk in physical_disks {
Self::physical_disk_upsert_on_connection(&conn, &opctx, physical_disk)
// XXX This is wrong.
//
// Namely, calling this method on the datastore, instead
// of re-using `conn`, checks out a new connection from
// the connection pool and uses that. This new
// connection is not participating in the transaction,
// and does not benefit from transactional semantics.
//
// So, that's not right. But in:
// https://github.com/oxidecomputer/omicron/pull/5172/commits/40a561e87d05d0938baf8f8023f26c0cbbffc8ff
//
// I noticed that this led to some weird behavior on
// the "Helios / Deploy" bot, within Nexus:
//
// https://buildomat.eng.oxide.computer/wg/0/artefact/01HT109ZD24S4QN2SM2M6R1MRK/iYfvoiGwjJgVZtHc12zJnIn43InreqbbJsDzLiFzUHLPAVpZ/01HT10ATZSX64JZVT409C9WV44/01HT1CG9CV7BWPC1YY8STEQ2N2/oxide-nexus:default.log?format=x-bunyan
//
// (try looking for "Timed out in bb8").
//
// In particular, it looks like this request gets here,
// and then possibly hangs? I'm not sure if it's
// blocked, or what exactly, but it appears to be
// causing OTHER connections in the pool to start
// failing.
//
// I'm changing this behavior to be "intentionally
// wrong" as a coarse repro case, though I'd like to
// work towards a much smaller repro case to understand
// what's happening here.
self.physical_disk_upsert(&opctx, physical_disk)
.await
.map_err(|e| {
error!(log, "Failed to upsert physical disk"; "err" => #%e);
Expand Down
Loading