WIP: Allow control of tests run in VMs on the host #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a reworking of `falcon_runner.rs` that splits the work between a `FalconTest` harness that allows direct manipulation of the runner so that the full falcon API is available, while also wrapping the bash nonsense to run a test and get the result back. The harness is minimal at this point, and purposefully so, to allow for complete flexibility. This allows the user to launch multiple VMs, run arbitrary tests, mount arbitrary data directories into VMs, etc... We can provide more batteries included, perhaps with escape hatches, and we can also simplify further with attribute macros for the batteries included parts.
andrewjstone
commented
Mar 27, 2024
| let cargo_bay = tempdir().unwrap(); | ||
| info!(log, "Set cargo-bay to {} on host machine", cargo_bay.path()); | ||
| let test_name = "launch"; | ||
| let source_test_path = &args[0]; |
There was a problem hiding this comment.
This is a hack to easily find the source binary. It works only if the test to run in the VM is part of the same test binary generated by cargo.
andrewjstone
commented
Mar 27, 2024
|
|
||
| // Mount the cargo-bay into the VM | ||
| test.runner() | ||
| .mount(cargo_bay.path(), "/opt/cargo-bay", vm) |
There was a problem hiding this comment.
"/opt/cargo-bay", and the host path are both arbitrary, and can be anything. As an example, if a test wanted to launch multiple VMs they may all use the same VM mount path, but have different local directories. This is part of the reason for allowing full access to the falcon API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworking of
falcon_runner.rsthat splits the work between aFalconTestharness that allows direct manipulation of the runner so that the full falcon API is available, while also wrapping the bash nonsense to run a test and get the result back.The harness is minimal at this point, and purposefully so, to allow for complete flexibility. This allows the user to launch multiple VMs, run arbitrary tests, mount arbitrary data directories into VMs, etc... We can provide more batteries included, perhaps with escape hatches, and we can also simplify further with attribute macros for the batteries included parts.
The example test can be run in the following manner, notably without a nextest target runner.
pfexecmay cause problems with permissions when forced to rebuild however.Notice that we run the "host" test from nextest here, and that test spins up a VM and runs a test (
launch) inside it.