[authz-macros] accept an optional input_key argument #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5 [skip ci]
Created using spr 1.3.5
sunshowers
changed the base branch from
sunshowers/spr/main.authz-macros-accept-an-optional-input_key-argument
to
main
Created using spr 1.3.5
Created using spr 1.3.5
smklein
approved these changes
Dec 15, 2023
smklein
reviewed
Dec 15, 2023
Created using spr 1.3.5
3 tasks
sunshowers
deleted the
sunshowers/spr/authz-macros-accept-an-optional-input_key-argument
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases including composite keys, it can be better to make the outside
representation of the primary key some kind of struct, rather than passing
around tuples of various types.
Enable that in the
authz_resourcemacro by allowing users to specify anoptional
input_keyargument, which represents a better view into the primarykey.
I'm not entirely sure that the
Fromtrait is the right thing to use here, butit seems like a pretty low-cost decision to change in the future.
As part of this PR I also switched to the prettyplease crate, which as the
README explains is more suitable for generated code than rustfmt:
https://crates.io/crates/prettyplease