Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Fix wording and comments #4695

Merged
merged 1 commit into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal-dns/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ impl Host {
///
/// `DnsConfigBuilder` provides a much simpler interface for constructing DNS
/// zone data than using `DnsConfig` directly. That's because it makes a number
/// of assumptions that are true of the control plane DNS zone (all described in
/// RFD 248), but not true in general about DNS zones:
/// of assumptions that are true of the control plane DNS zones (all described
/// in RFD 248), but not true in general about DNS zones:
///
/// - We assume that there are only two kinds of hosts: a "sled" (an illumos
/// global zone) or a "zone" (an illumos non-global zone). (Both of these are
Expand Down
10 changes: 3 additions & 7 deletions sled-agent/src/rack_setup/service.rs
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,11 @@ impl RackSetupService {
/// Arguments:
/// - `log`: The logger.
/// - `config`: The config file, which is used to setup the rack.
/// - `storage_resources`: All the disks and zpools managed by this sled
/// - `storage_manager`: A handle for interacting with the storage manager
/// task
/// - `local_bootstrap_agent`: Communication channel by which we can send
/// commands to our local bootstrap-agent (e.g., to initialize sled
/// commands to our local bootstrap-agent (e.g., to start sled-agents)
/// - `bootstore` - A handle to call bootstore APIs
/// agents).
pub(crate) fn new(
log: Logger,
config: Config,
Expand Down Expand Up @@ -1083,10 +1083,6 @@ impl ServiceInner {
)
.await?;

// TODO Questions to consider:
// - What if a sled comes online *right after* this setup? How does
// it get a /64?

Ok(())
}
}
Expand Down
Loading