-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rust crate tokio-tungstenite to 0.20 #4403
Conversation
3a7a826
to
b23c01f
Compare
45e979b
to
371d328
Compare
371d328
to
1d231f8
Compare
Asking for review because the semantics of tokio-tungstenite have changed from tracking a max send queue of messages, to a max write buffer size. Based on the default 128KB default write buffer size, I think a max write buffer size of 2MB should be good. (I figure most messages are pretty small and 2MB corresponds to 4096 512-byte messages). |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, 2MiB ought to be enough for anyone -- at least, it's the same total amount of serial spew history that we keep buffered in propolis itself, and linux guests generally run the UART at 115200 baud (14.4KB/s), so it should be exceedingly rare that a brief connection hiccup turns into a spurious buffer full error.
This PR contains the following updates:
0.18
->0.20
Release Notes
snapview/tokio-tungstenite (tokio-tungstenite)
v0.20.1
Compare Source
tungstenite
.v0.20.0
Compare Source
Sink::send()
andSink::feed()
, seetungstenite
's changelog for more details.v0.19.0
Compare Source
connect()
helpers.Sink
for theWebSocketStream
, so it does not return an error when it’s not necessary (whenpoll_flush()
is called on a connection that has just been closed).rustls
TLS backend expected domain in a certain format and reject IPv6 addresses if they contained square brackets in them.Configuration
📅 Schedule: Branch creation - "after 8pm,before 6am" in timezone America/Los_Angeles, Automerge - "after 8pm,before 6am" in timezone America/Los_Angeles.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.