Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate tokio-tungstenite to 0.20 #4403

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

oxide-renovate[bot]
Copy link
Contributor

@oxide-renovate oxide-renovate bot commented Nov 1, 2023

This PR contains the following updates:

Package Type Update Change
tokio-tungstenite workspace.dependencies minor 0.18 -> 0.20

Release Notes

snapview/tokio-tungstenite (tokio-tungstenite)

v0.20.1

Compare Source

  • Fix RUSTSEC-2023-0053.
  • Fix transitive CVE-2023-43669 from tungstenite.

v0.20.0

Compare Source

v0.19.0

Compare Source

  • Allow users to enable/disable Nagle algorithm when using connect() helpers.
  • Improve the behavior of the Sink for the WebSocketStream, so it does not return an error when it’s not necessary (when poll_flush() is called on a connection that has just been closed).
  • Workaround an issue where rustls TLS backend expected domain in a certain format and reject IPv6 addresses if they contained square brackets in them.
  • Update dependencies and remove unused errors.

Configuration

📅 Schedule: Branch creation - "after 8pm,before 6am" in timezone America/Los_Angeles, Automerge - "after 8pm,before 6am" in timezone America/Los_Angeles.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@oxide-renovate oxide-renovate bot added the dependencies Pull requests that update a dependency file label Nov 1, 2023
@oxide-renovate oxide-renovate bot force-pushed the renovate/tokio-tungstenite-0.x branch 5 times, most recently from 3a7a826 to b23c01f Compare November 8, 2023 04:24
@oxide-renovate oxide-renovate bot force-pushed the renovate/tokio-tungstenite-0.x branch 2 times, most recently from 45e979b to 371d328 Compare November 14, 2023 04:07
@oxide-renovate oxide-renovate bot force-pushed the renovate/tokio-tungstenite-0.x branch from 371d328 to 1d231f8 Compare November 15, 2023 04:08
@oxide-renovate oxide-renovate bot changed the title chore(deps): update rust crate tokio-tungstenite to 0.20 Update Rust crate tokio-tungstenite to 0.20 Nov 17, 2023
@sunshowers sunshowers requested review from lifning, leftwo and jgallagher and removed request for leftwo November 20, 2023 00:58
@sunshowers
Copy link
Contributor

Asking for review because the semantics of tokio-tungstenite have changed from tracking a max send queue of messages, to a max write buffer size. Based on the default 128KB default write buffer size, I think a max write buffer size of 2MB should be good. (I figure most messages are pretty small and 2MB corresponds to 4096 512-byte messages).

@oxide-renovate
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Contributor

@lifning lifning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, 2MiB ought to be enough for anyone -- at least, it's the same total amount of serial spew history that we keep buffered in propolis itself, and linux guests generally run the UART at 115200 baud (14.4KB/s), so it should be exceedingly rare that a brief connection hiccup turns into a spurious buffer full error.

gateway/src/serial_console.rs Outdated Show resolved Hide resolved
@sunshowers sunshowers enabled auto-merge (squash) November 22, 2023 00:52
@sunshowers sunshowers merged commit c339fc7 into main Nov 22, 2023
21 of 22 checks passed
@sunshowers sunshowers deleted the renovate/tokio-tungstenite-0.x branch November 22, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants