Add type conversions for EarlyNetworkConfig upgrade #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds deserialization and conversion support for v0 and v1 of EarlyNetworkConfig types. Future commits will add support for writing the v1 version back to the bootstore ledger if necessary. Unit tests for conversion also coming soon.
jgallagher
reviewed
Oct 17, 2023
|
After discussion with @jgallagher, it seems unnecessary and potentially dangerous to write the updated schema back to the ledger since we can deterministically convert from |
This reverts commit 252e2a1.
andrewjstone
commented
Oct 18, 2023
| /// Convert from `RackNetworkConfigV0` to `RackNetworkConfigV1` | ||
| /// | ||
| /// We cannot use `From<RackNetworkConfigV0> for `RackNetworkConfigV1` | ||
| /// because the `rack_network` field does not exist in `RackNetworkConfigV0` |
There was a problem hiding this comment.
Suggested change
| /// because the `rack_network` field does not exist in `RackNetworkConfigV0` | |
| /// because the `rack_subnet` field does not exist in `RackNetworkConfigV0` |
rcgoodfellow
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds deserialization and conversion support for v0 and v1 of EarlyNetworkConfig types. Future commits will add support for writing the v1 version back to the bootstore ledger if necessary. Unit tests for conversion also coming soon.