[update-engine] fix buffer tests #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
Created using spr 1.3.4 [skip ci]
|
Err, need to make a change still. |
Created using spr 1.3.4
Created using spr 1.3.4
andrewjstone
approved these changes
Sep 29, 2023
Created using spr 1.3.4 [skip ci]
sunshowers
force-pushed
the
sunshowers/spr/update-engine-fix-buffer-tests
branch
from
e360e1f to
72aaaba
Compare
sunshowers
changed the base branch from
sunshowers/spr/main.update-engine-fix-buffer-tests
to
main
sunshowers
added a commit
that referenced
this pull request
Oct 13, 2023
* For failures, track the parent key that failed (similar to aborts). * Track the last root event index that causes data for a step to be updated -- we're going to use this in the line-based displayer. * Add tests. Depends on #4163.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I'd made a couple of mistakes while writing tests:
the fact that...