Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silo creation should accept TLS certificates #3138

Merged
merged 3 commits into from
May 17, 2023
Merged

Conversation

davepacheco
Copy link
Collaborator

This is necessary because in a real system:

  1. You may only be able to access a Silo from its own console/API endpoint (this is not yet implemented, but I assume it's coming)
  2. Nexus will not be listening on HTTP (only HTTPS). (This isn't true today, but needs to be soon outside of development.)
  3. There is currently no way to administer the certificates of another Silo. (We generally don't want to allow this sort of thing. See better flesh out operator privileges in other Silos #1681. The list of TLS certificates is probably an exception similar to identity providers -- if it gets messed up, you can't log into the Silo directly to fix it. But anyway, we haven't implemented it yet.)

Thus, without providing certificates when you create the Silo, you'd have no way to log into it. We get away without this today because (1) and (2) aren't true yet. Nexus does listen on HTTP and you can currently use any Silo's endpoint to log into any other Silo. Also, until recently (with #3095), certificates were fleet-wide.

@davepacheco davepacheco requested a review from luqmana May 17, 2023 17:32
Copy link
Contributor

@luqmana luqmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into and fleshing out this space! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants