Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sled-agent] Allow synthetic disks to be used as M.2s and U.2s. #2976

Merged
merged 1 commit into from
May 1, 2023

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented May 1, 2023

This fixes a bug where the internal zpools created by ./tools/create_virtual_hardware.sh were ignored by the sled agent - this utility is used in other locations to access "m.2 datasets".

@smklein smklein requested a review from andrewjstone May 1, 2023 21:18
@smklein
Copy link
Collaborator Author

smklein commented May 1, 2023

Found this while debugging #2972 , figured I'd split it off to its own PR

Copy link
Contributor

@andrewjstone andrewjstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smklein smklein enabled auto-merge (squash) May 1, 2023 22:17
@smklein smklein merged commit b37d202 into main May 1, 2023
@smklein smklein deleted the synthetic-m2 branch May 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants