Stop deleting chelsio addresses during uninstall #2953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Running on rack2 and calling
omicron-package uninstall
would involve a fatal termination of the connection, as it would delete thecxgbe0/ll
andcxgbe1/ll
IP addresses necessary for contacting the sled.After this PR
Those addresses are left alone. This is pretty useful for development, as it allows us to run
uninstall
to cleanly wipe a Gimlet, preparing it for future "clean installs".