Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop deleting chelsio addresses during uninstall #2953

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Conversation

smklein
Copy link
Collaborator

@smklein smklein commented Apr 30, 2023

Before this PR

Running on rack2 and calling omicron-package uninstall would involve a fatal termination of the connection, as it would delete the cxgbe0/ll and cxgbe1/ll IP addresses necessary for contacting the sled.

After this PR

Those addresses are left alone. This is pretty useful for development, as it allows us to run uninstall to cleanly wipe a Gimlet, preparing it for future "clean installs".

@smklein smklein requested review from bnaecker and jclulow April 30, 2023 03:04
@smklein
Copy link
Collaborator Author

smklein commented Apr 30, 2023

I previously managed my "write-compile-test" loop on Gimlets with the following:

  1. Before installing new control plane software, delete /var/oxide to remove all Sled configs
  2. Rely heavily on the sled agent functionality to "delete all old zones and vnics" on boot

However, this is getting less reasonable, because:

  1. Sled Agent must manage durable storage for configs, zones, explicitly #2888 is coming, which means sled configs will be stored on zpool datasets, rather than /var/oxide.
  2. [sled-agent] Re-construct Zone management state within sled agent after reboot #725 should also be done, which means that sled agent should reconstruct state on reboot, rather than destroy it.

Ergo, I need to have a better way to get Gimlets to a "clean slate" - by fixing the uninstall command, this should be a universal command to wipe (almost all) signs of control plane usage from prior installations.

smklein added a commit that referenced this pull request Apr 30, 2023
Copy link
Contributor

@luqmana luqmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! beats having to get onto the console to fix

@smklein smklein merged commit 261b9cc into main Apr 30, 2023
@smklein smklein deleted the stop-deleting-chelsio branch April 30, 2023 05:45
smklein added a commit that referenced this pull request Apr 30, 2023
## Before this PR

Running on rack2 and calling `omicron-package uninstall` would involve a
fatal termination of the connection, as it would delete the `cxgbe0/ll`
and `cxgbe1/ll` IP addresses necessary for contacting the sled.

## After this PR

Those addresses are left alone. This is pretty useful for development,
as it allows us to run `uninstall` to cleanly wipe a Gimlet, preparing
it for future "clean installs".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants