Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update-engine] Tweaks to allow engine execution future to be Send #2860

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

jgallagher
Copy link
Contributor

While integrating update-engine and wicketd, I bumped into a couple issues trying to tokio::spawn() a future involving an UpdateEngine where the compiler didn't think the future was Send even though it should have been; these changes taught the compiler what it needed to know.

@jgallagher jgallagher requested a review from sunshowers April 17, 2023 15:47
Copy link
Contributor

@sunshowers sunshowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jgallagher jgallagher enabled auto-merge (squash) April 17, 2023 16:54
@jgallagher jgallagher merged commit 4d442b4 into main Apr 17, 2023
@jgallagher jgallagher deleted the update-engine-send branch April 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants