Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force-attach devinfo tree when detecting if system is a Gimlet #2400

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Don't force-attach devinfo tree when detecting if system is a Gimlet #2400

merged 1 commit into from
Feb 23, 2023

Conversation

bnaecker
Copy link
Collaborator

No description provided.

@bnaecker
Copy link
Collaborator Author

I tested this on my local machine, where the previous version would indeed fail with EACCES. This should be able to detect if the system is a Gimlet with no elevated permissions. Thanks @jclulow!

@bnaecker bnaecker requested a review from jclulow February 21, 2023 20:30
@bnaecker bnaecker mentioned this pull request Feb 21, 2023
Open
@bnaecker bnaecker merged commit cb3d713 into main Feb 23, 2023
@bnaecker bnaecker deleted the no-force-attach-devinfo branch February 23, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luqmana luqmana luqmana approved these changes

@jclulow jclulow Awaiting requested review from jclulow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnaecker @luqmana