Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wicket packaging #2245

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Wicket packaging #2245

merged 8 commits into from
Feb 2, 2023

Conversation

andrewjstone
Copy link
Contributor

@andrewjstone andrewjstone commented Jan 28, 2023

Package up wicketd and wicket with omicron-package. I tested this out locally, and it seemed to work.

There are a couple things remaining to do:

  • We need to be able to have the BOOTSTRAP_ARTIFACT_PORT listen on a bootstrap address. It's currently hardcoded to use localhost which is wrong.
  • Should sled-agent construct a config file for wicket so it knows how to contact wicketd? Currently the wicketd port is just hardcoded inside wicket.

The first should probably be done in this PR. The second can likely wait until we figure out how we are going to launch wicket.

common/src/address.rs Outdated Show resolved Hide resolved
@andrewjstone andrewjstone marked this pull request as ready for review January 31, 2023 01:36
@andrewjstone
Copy link
Contributor Author

I had a brief chat in network channel with @rcgoodfellow, and he wasn't expecting to advertise bootstrap prefixes from the switch zone. He said it can be done, but the alternative is to move the artifact server into the sled-agent itself. We were going to do this anyway for recovery, so maybe having it in one place makes sense. More to be discussed tomorrow.

CC @sunshowers

@andrewjstone
Copy link
Contributor Author

andrewjstone commented Feb 1, 2023

I had a brief chat in network channel with @rcgoodfellow, and he wasn't expecting to advertise bootstrap prefixes from the switch zone. He said it can be done, but the alternative is to move the artifact server into the sled-agent itself. We were going to do this anyway for recovery, so maybe having it in one place makes sense. More to be discussed tomorrow.

This has evolved into a larger discussion. For now, since the wicketd artifact server isn't actually in use yet, I suggest doing any networking or zone changes in a follow up PR, rather than cramming them in here.

@sunshowers
Copy link
Contributor

Looks good, thanks!

@andrewjstone andrewjstone merged commit b231a80 into main Feb 2, 2023
@andrewjstone andrewjstone deleted the wicket-packaging branch February 2, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants