Fix copy-pasta in oximeter-db internal datum type representation #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes copy-paste error when converting between `oximeter`'s `DatumType` and the type used to represent it in the database, `oximeter_db::model::DbDatumType`. - Adds a slew of sanity checks verifying these mechanical conversions to prevent regressions
smklein
approved these changes
Aug 10, 2022
ahl
reviewed
Aug 10, 2022
| @@ -191,7 +191,7 @@ impl From<DatumType> for DbDatumType { | |||
| DatumType::String => DbDatumType::String, | |||
| DatumType::Bytes => DbDatumType::Bytes, | |||
| DatumType::CumulativeI64 => DbDatumType::CumulativeI64, | |||
| DatumType::CumulativeF64 => DbDatumType::CumulativeI64, | |||
There was a problem hiding this comment.
Yeah, who reviewed this thing anyway?!
leftwo
pushed a commit
that referenced
this pull request
Nov 27, 2024
Crucible Changes: Send deactivate flush if `need_flush` is set (#1573) Improve DTrace scripts. (#1574) Move reconcile-specific data into `ReconcileData` struct (#1567) Remove unprinted header item from sled_upstairs_info (#1566) Downgrade warning about skipping IO on all 3x Downstairs (#1564) Propolis changes: Wire up viona params from illumos#16738
leftwo
added a commit
that referenced
this pull request
Nov 27, 2024
Crucible Changes: Send deactivate flush if `need_flush` is set (#1573) Improve DTrace scripts. (#1574) Move reconcile-specific data into `ReconcileData` struct (#1567) Remove unprinted header item from sled_upstairs_info (#1566) Downgrade warning about skipping IO on all 3x Downstairs (#1564) Propolis changes: Wire up viona params from illumos#16738 Co-authored-by: Alan Hanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oximeter'sDatumTypeand the type used to represent it in the database,oximeter_db::model::DbDatumType.prevent regressions