Use net0 vnic for maghemite #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @bnaecker's suggestion in #1212 (comment), this changes bootstrap-agent to pass
net0/linklocal(i.e., one of the VNICs created bycreate_virtual_hardware.sh) to magehmite instead of creating a$PHYS/linklocal(e.g.,igb0/linklocal).This mostly involved extracting the bit of code from
opte.rsthat ensuresnet{0,1}/linklocalare set up to somewhere it could be used by both opte and bootstrap-agent. I am not wedded to its new location or names by any means; please don't hesitate to suggest a different place / function name forunderlay::find_nics().While I was here I tried to address the TODO comment about passing multiple interfaces to maghemite, but ran into some issues testing that on my VMs. I'm going to continue poking at that, but will put it in a followup PR once it's working.