Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail obviously if the kernel does not support the xde driver #1070

Merged
merged 1 commit into from
May 16, 2022
Merged

Fail obviously if the kernel does not support the xde driver #1070

merged 1 commit into from
May 16, 2022

Conversation

bnaecker
Copy link
Collaborator

No description provided.

@bnaecker bnaecker requested review from jmpesp and smklein May 13, 2022 22:37
@bnaecker
Copy link
Collaborator Author

This will address #1063. Here's a snippet of the log, showing the error, when running the sled agent against stock Helios:

{"msg":"request completed","v":0,"name":"SledAgent","level":30,"time":"2022-05-13T22:36:41.946229047Z","hostname":"feldspar","pid":1276,"uri":"/start_sled","method":"PUT","req_id":"4dd2e63d-93a4-49be-b11e-b9c291bd9001","remote_addr":"[fdb0:b42e:99fe:859::1]:58452","local_addr":"[fdb0:b42e:99fe:859::1]:12346","component":"dropshot (Bootstrap)","error_message_external":"Internal Server Error","error_message_internal":"Error starting sled agent: Could not start sled agent server: Error managing guest networking: The OS kernel does not support the xde driver. Please update the OS using `./tools/install_opte.sh` to provide kernel bits and the xde driver which are compatible.","response_code":"500"}

jmpesp
jmpesp approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@jmpesp jmpesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! Left one thought but it's not blocking.

sled-agent/src/opte/opte.rs Show resolved Hide resolved
@bnaecker bnaecker merged commit a1a5916 into main May 16, 2022
@bnaecker bnaecker deleted the yell-if-no-xde branch May 16, 2022 17:03
@bnaecker bnaecker mentioned this pull request May 24, 2022
Closed
leftwo pushed a commit that referenced this pull request Jan 10, 2024
Update Crucible and Propolis versions
b8fdf80 
Propolis changes since the last update:
Gripe when using non-raw block device
Update zerocopy dependency
nvme: Wire up GetFeatures command
Make Viona more robust in the face of errors
bump softnpu (#577)
Modernize 16550 UART

Crucible changes since the last update:
Don't check ROP if the scrub is done (#1093)
Allow crutest cli to be quiet on generic test (#1070)
Offload write encryption (#1066)
Simplify handling of BlockReq at program exit (#1085)
Update Rust crate byte-unit to v5 (#1054)
Remove unused fields in match statements, downstairs edition (#1084)
Remove unused fields in match statements and consolidate (#1083)
Add logger to Guest (#1082)
Drive hash / decrypt tests from Upstairs::apply
Wait to reconnect if auto_promote is false
Change guest work id from u64 -> GuestWorkId
remove BlockOp::Commit (#1072)
Various clippy fixes (#1071)
Don't panic if tasks are destroyed out of order
Update Rust crate reedline to 0.27.1 (#1074)
Update Rust crate async-trait to 0.1.75 (#1073)
Buffer should destructure to Vec when single-referenced
Don't fail to make unencrypted regions (#1067)
Fix shadowing in downstairs (#1063)
Single-task refactoring (#1058)
Update Rust crate tokio to 1.35 (#1052)
Update Rust crate openapiv3 to 2.0.0 (#1050)
Update Rust crate libc to 0.2.151 (#1049)
Update Rust crate rusqlite to 0.30 (#1035)
@leftwo leftwo mentioned this pull request Jan 10, 2024
Merged
leftwo added a commit that referenced this pull request Jan 11, 2024
@leftwo
Update Crucible and Propolis versions (#4795)
19059b1 
Propolis changes since the last update:
Gripe when using non-raw block device
Update zerocopy dependency
nvme: Wire up GetFeatures command
Make Viona more robust in the face of errors
bump softnpu (#577)
Modernize 16550 UART

Crucible changes since the last update:
Don't check ROP if the scrub is done (#1093)
Allow crutest cli to be quiet on generic test (#1070)
Offload write encryption (#1066)
Simplify handling of BlockReq at program exit (#1085)
Update Rust crate byte-unit to v5 (#1054)
Remove unused fields in match statements, downstairs edition (#1084)
Remove unused fields in match statements and consolidate (#1083)
Add logger to Guest (#1082)
Drive hash / decrypt tests from Upstairs::apply
Wait to reconnect if auto_promote is false
Change guest work id from u64 -> GuestWorkId
remove BlockOp::Commit (#1072)
Various clippy fixes (#1071)
Don't panic if tasks are destroyed out of order
Update Rust crate reedline to 0.27.1 (#1074)
Update Rust crate async-trait to 0.1.75 (#1073)
Buffer should destructure to Vec when single-referenced
Don't fail to make unencrypted regions (#1067)
Fix shadowing in downstairs (#1063)
Single-task refactoring (#1058)
Update Rust crate tokio to 1.35 (#1052)
Update Rust crate openapiv3 to 2.0.0 (#1050)
Update Rust crate libc to 0.2.151 (#1049)
Update Rust crate rusqlite to 0.30 (#1035)

---------

Co-authored-by: Alan Hanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smklein smklein smklein approved these changes

@jmpesp jmpesp jmpesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnaecker @jmpesp @smklein