Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for modifying IP subnets of a VPC Subnet #1019

Merged
merged 2 commits into from
May 5, 2022

Conversation

bnaecker
Copy link
Collaborator

@bnaecker bnaecker commented May 5, 2022

Previously, the VpcSubnetUpdate type allowed users to specify a new
IPv4 or IPv6 subnetwork for the VPC Subnet. That is now only supported
by creating a new subnet.

Previously, the `VpcSubnetUpdate` type allowed users to specify a new
IPv4 or IPv6 subnetwork for the VPC Subnet. That is now only supported
by creating a new subnet.
@bnaecker bnaecker requested a review from smklein May 5, 2022 19:51
@bnaecker
Copy link
Collaborator Author

bnaecker commented May 5, 2022

This will address #964

@bnaecker
Copy link
Collaborator Author

bnaecker commented May 5, 2022

There was another transient timeout failure here, presumably due to oversubscription of the macOS test runners again.

Copy link
Collaborator

@smklein smklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple questions on the tests

nexus/test-utils/src/resource_helpers.rs Show resolved Hide resolved
nexus/tests/integration_tests/subnet_allocation.rs Outdated Show resolved Hide resolved
nexus/tests/integration_tests/subnet_allocation.rs Outdated Show resolved Hide resolved
@bnaecker bnaecker enabled auto-merge (squash) May 5, 2022 23:04
@bnaecker bnaecker merged commit 2f98c6c into main May 5, 2022
@bnaecker bnaecker deleted the cannot-modify-ip-subnets branch May 5, 2022 23:57
leftwo pushed a commit that referenced this pull request Nov 15, 2023
Crucible changes:
test-crudd can collect more info, test_up can be gentle (#997)
Decrypt without holding the downstairs lock (#1021)
Add raw file backend (#991)
Don't hold the Downstairs lock while doing encryption (#1019)
Antagonize the Crucible Agent (#1011)
The Pantry should reject non-block sized writes (#1013)
Propolis changes:
Just the commit that updates Crucible
leftwo added a commit that referenced this pull request Nov 16, 2023
Crucible changes:
test-crudd can collect more info, test_up can be gentle (#997) 
Decrypt without holding the downstairs lock (#1021) 
Add raw file backend (#991)
Don't hold the Downstairs lock while doing encryption (#1019) 
Antagonize the Crucible Agent (#1011)
The Pantry should reject non-block sized writes (#1013)

Propolis changes:
make headroom for linux virtio/9p client impl (#565)
Guarantee Tokio access for Entity methods

---------

Co-authored-by: Alan Hanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants