Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT /omicron-zone -- stop provisioning datasets! #6991

Open
smklein opened this issue Nov 5, 2024 · 2 comments · Fixed by #7006 · May be fixed by #7160
Open

PUT /omicron-zone -- stop provisioning datasets! #6991

smklein opened this issue Nov 5, 2024 · 2 comments · Fixed by #7006 · May be fixed by #7160
Assignees

Comments

@smklein
Copy link
Collaborator

smklein commented Nov 5, 2024

This is a historical artifact -- we used to provision datasets in the PUT /omicron-zone API, but should now be able to rely on reconfigurator's executor to provision necessary datasets. This issue tracks removing the logic in:

// TODO(https://github.com/oxidecomputer/omicron/issues/6043):
// - If these are the set of filesystems, we should also consider
// removing the ones which are not listed here.
// - It's probably worth sending a bulk request to the storage system,
// rather than requesting individual datasets.
for zone in &requested_zones.zones {
let Some(dataset_name) = zone.dataset_name() else {
continue;
};
// First, ensure the dataset exists
let dataset_id = zone.id.into_untyped_uuid();
self.inner
.storage
.upsert_filesystem(dataset_id, dataset_name)
.await?;
}

(Or, at least, replacing it with a check that these datasets exist)

@smklein smklein self-assigned this Nov 5, 2024
@smklein
Copy link
Collaborator Author

smklein commented Nov 5, 2024

Blocked by #6989 , otherwise RSS will presumably break if these lines are changed. RSS will need to request the datasets itself (this is fixed in #7000 )

@smklein
Copy link
Collaborator Author

smklein commented Nov 23, 2024

Re-opening this issue; it's getting reverted by #7157

@smklein smklein reopened this Nov 23, 2024
smklein added a commit that referenced this issue Nov 25, 2024
Calls to `PUT` zones will now check that datasets exist -- as they
should be initialized, with prior calls -- rather than
forcefully creating them.

This PR checks that datasets exist in the "configuration", rather than
querying inventory.

Fixes #6991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant