Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sled-storage] Remove "self-managed" physical disks #5328

Closed
Tracked by #5149
smklein opened this issue Mar 25, 2024 · 0 comments · Fixed by #5987
Closed
Tracked by #5149

[sled-storage] Remove "self-managed" physical disks #5328

smklein opened this issue Mar 25, 2024 · 0 comments · Fixed by #5987
Labels
bootstrap services For those occasions where you want the rack to turn on Sled Agent Related to the Per-Sled Configuration and Management storage Related to storage.

Comments

@smklein
Copy link
Collaborator

smklein commented Mar 25, 2024

As a part of #5172 , we started using a "ledger of control-plane disks" stored on M.2s. This tells sled agents, durably, "which U.2s they should use", as instructed by Nexus. This is stored in a ledger for bootstrapping purposes -- this info needs to be accessible before Nexus/CRDB are up and running.

However, as a bridge to keep "ledger-less" deployments working, a kludge exists in this PR to automatically "self-manage" U.2s on devices which have no ledgers, but do have U.2s with zpools.

This works as a transitional measure, but should be removed once we're confident we've migrated to a world where deployments are using a ledger.
@smklein smklein added storage Related to storage. Sled Agent Related to the Per-Sled Configuration and Management bootstrap services For those occasions where you want the rack to turn on labels Mar 25, 2024
@smklein smklein changed the title Remove "self-managed" physical disks [sled-storage] Remove "self-managed" physical disks Mar 25, 2024
This was referenced Mar 25, 2024
Merged
Closed
Closed
Closed
@smklein smklein mentioned this issue Jul 2, 2024
Merged
smklein added a commit that referenced this issue Jul 15, 2024
@smklein
[sled-agent] Stop self-managing physical disks (#5987)
031b5ec 
Fixes #5328

This was an old kludge for backwards compatibility, we should be able to
rely on ledgers explicitly for this purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bootstrap services For those occasions where you want the rack to turn on Sled Agent Related to the Per-Sled Configuration and Management storage Related to storage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[sled-agent] Stop self-managing physical disks oxidecomputer/omicron
1 participant
@smklein