Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace lazy_static with once_cell #4697

Closed
smklein opened this issue Dec 14, 2023 · 1 comment · Fixed by #4699
Closed

replace lazy_static with once_cell #4697

smklein opened this issue Dec 14, 2023 · 1 comment · Fixed by #4699
Assignees
@smklein
Labels
cleanup Code cleanliness dependencies Pull requests that update a dependency file

Comments

@smklein
Copy link
Collaborator

smklein commented Dec 14, 2023

We started doing this a bit already (see: #2934 ) but it would be nice to remove the lazy_static dependency here. It's an old crate that hasn't been updated in several years.
@smklein smklein added dependencies Pull requests that update a dependency file cleanup Code cleanliness labels Dec 14, 2023
@smklein smklein self-assigned this Dec 14, 2023
@sunshowers
Copy link
Contributor

sunshowers commented Dec 14, 2023 •
edited
Loading

Yep we shouldn't be using lazy_static any more -- and in fact can switch to std::sync::OnceLock (the Rust std import of once_cell) if we don't need the Lazy type.

@smklein smklein mentioned this issue Dec 14, 2023
Merged
smklein added a commit that referenced this issue Dec 20, 2023
@smklein
Remove lazy_static in favor of once_cell (#4699)
94944cc 
Fixes #4697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smklein smklein

Labels
cleanup Code cleanliness dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove lazy_static in favor of once_cell oxidecomputer/omicron
2 participants
@sunshowers @smklein