Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP Pools: include is_default value in the list/get ip pool response #4005

Closed
askfongjojo opened this issue Aug 31, 2023 · 3 comments · Fixed by #4007
Closed

IP Pools: include is_default value in the list/get ip pool response #4005

askfongjojo opened this issue Aug 31, 2023 · 3 comments · Fixed by #4007

Comments

@askfongjojo
Copy link

The is_default attribute is currently missing from the get response body. It'll be useful for the admin to know whether a default pool is made for a silo and which one it is, instead of relying on the name or description to provide that information.
@rmustacc
Copy link

Should this be on the IP pool or just something that's on the silo? I think a given pool's default status is going to change a bunch especially with project defaults.

@david-crespo
Copy link
Contributor

See #4002 (comment) — I was thinking the same @rmustacc. The association could be its own entity. That doesn’t preclude putting together a nice view of all the default pools together.

@david-crespo
Copy link
Contributor

david-crespo commented Sep 1, 2023 •
edited
Loading

I'm going to add is_default to the IpPool view for now for consistency because it's already on the model, but be assured I still plan on reworking on the data model, and then the view will change back. I plan to make these changes very soon.

david-crespo added a commit that referenced this issue Sep 1, 2023
@david-crespo
add is_default to views::IpPool. closes #4005
cc6c721
@david-crespo david-crespo mentioned this issue Sep 1, 2023
Merged
david-crespo added a commit that referenced this issue Sep 1, 2023
@david-crespo
Small IP pools fixes (#4007)
db702a2 
Followup to #3985, closes #4005.

- Add `is_default` to IP pool response
- Inline `ip_pools_fetch` into the one callsite and delete it (per
discussion
#3985 (comment))
- Other small test tweaks suggested by @luqmana
@askfongjojo askfongjojo mentioned this issue Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Small IP pools fixes oxidecomputer/omicron
3 participants
@rmustacc @david-crespo @askfongjojo