Skip to content

Commit

Permalink
include backtrace from omdb panic from within omdb tests (#6516)
Browse files Browse the repository at this point in the history
  • Loading branch information
davepacheco authored Sep 19, 2024
1 parent 7a4e3a7 commit 8763306
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions dev-tools/omdb/tests/test_all_output.rs
Original file line number Diff line number Diff line change
Expand Up @@ -502,11 +502,15 @@ async fn do_run_extra<F>(
tokio::task::spawn_blocking(move || {
let exec = modexec(
Exec::cmd(cmd_path)
// Set RUST_BACKTRACE for consistency between CI and
// developers' local runs. We set it to 0 only to match
// what someone would see who wasn't debugging it, but we
// could as well use 1 or "full" to store that instead.
.env("RUST_BACKTRACE", "0")
// Set RUST_BACKTRACE explicitly for consistency between CI
// and developers' local runs. We set it to 1 so that in
// the event of a panic, particularly in CI, we have more
// information about what went wrong. But we set
// RUST_LIB_BACKTRACE=1 so that we don't get a dump to
// stderr for all the Errors that get created and handled
// gracefully.
.env("RUST_BACKTRACE", "1")
.env("RUST_LIB_BACKTRACE", "0")
.args(&owned_args),
);
run_command(exec)
Expand Down

0 comments on commit 8763306

Please sign in to comment.